Skip to content

Add Swiftly toolchain management #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 18, 2025
Merged

Add Swiftly toolchain management #1717

merged 9 commits into from
Jul 18, 2025

Conversation

roulpriya
Copy link
Contributor

@roulpriya roulpriya commented Jul 14, 2025 •
edited by matthewbastien
Loading

Description

  • Refactored Swiftly code from toolchain.ts to swiftly.ts
  • Added list-available with json output

Issue: #1739

Tasks

  • Required tests have been written
  • Documentation has been updated
  • Added an entry to CHANGELOG.md if applicable

matthewbastien
matthewbastien approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few things to clean up and a question about the failure paths for swiftlyToolchain().

matthewbastien
matthewbastien requested changes Jul 14, 2025
View reviewed changes
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Meant to request changes, not approve.

@roulpriya roulpriya force-pushed the list-available-toolchain branch from 5a07f8b to 68790c8 Compare July 16, 2025 13:04
@roulpriya roulpriya marked this pull request as ready for review July 16, 2025 17:49
matthewbastien
matthewbastien reviewed Jul 16, 2025
View reviewed changes
award999
award999 reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@award999 award999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@roulpriya roulpriya force-pushed the list-available-toolchain branch from 25a4344 to 0048272 Compare July 17, 2025 17:23
matthewbastien
matthewbastien requested changes Jul 17, 2025
View reviewed changes
matthewbastien
matthewbastien approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@matthewbastien matthewbastien merged commit 7124b9a into swiftlang:main Jul 18, 2025
18 checks passed
@award999 award999 added the needs verification Issue has been fixed, but requires verification before closing label Jul 22, 2025
@award999 award999 moved this to Needs Verification in Swift Extension for Visual Studio Code Jul 22, 2025
@award999 award999 removed the needs verification Issue has been fixed, but requires verification before closing label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@award999 award999 award999 left review comments

@matthewbastien matthewbastien matthewbastien approved these changes

@adam-fowler adam-fowler Awaiting requested review from adam-fowler adam-fowler is a code owner

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

Assignees
No one assigned
Labels
gsoc2025
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roulpriya @matthewbastien @award999